Add exdoc:loaded event #2069
Add exdoc:loaded event #2069
Conversation
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12963745544/artifacts/2484808161 |
|
Just one commend and looks good to me. @liamcmitchell please let us know if you have any concerns, thanks! It may be worth documenting |
Co-authored-by: Jonatan Kłosko <[email protected]>
|
@garazdawi you will have to update Erlang. I plan to release v0.37.0-rc.0 this weekend, which should also be compatible with Erlang/OTP 28. |
| @@ -89,7 +89,7 @@ export function initialize () { | |||
| }) | |||
|
|
|||
| window.addEventListener('hashchange', markCurrentHashInSidebar) | |||
| window.addEventListener('swup:page:view', markCurrentHashInSidebar) | |||
| window.addEventListener('exdoc:loaded', markCurrentHashInSidebar) | |||
|
|
|||
| markCurrentHashInSidebar() | |||
There was a problem hiding this comment.
This is now duplicated and could be removed
There was a problem hiding this comment.
Thank you. I will push it soon. And to be clear, the next line does:
// Triggers layout, defer.
requestAnimationFrame(scrollNodeListToCurrentCategory)
That would still be fine, right?
There was a problem hiding this comment.
Ok, I can confirm this one breaks it and nothing is being marked on the sidebar. :)
There was a problem hiding this comment.
I will ship a new version with this still using swup:page:view. If you have suggestions on how to unify it, it would be very welcome. :) Thank you ❤️
There was a problem hiding this comment.
Sorry, I missed that this init is lazy and will always come after the first exdoc:loaded. Pushed changes to unify and make more clear in #2070
|
💚 💙 💜 💛 ❤️ |
Closes #2068.